generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use inject for non singleton class #1617
Draft
jorg3lopez
wants to merge
13
commits into
main
Choose a base branch
from
use-inject-for-non-singleton-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
100b54e
comment to start branch
jorg3lopez b5ddf86
getFieldsAnnotatedWithInstance helper method
jorg3lopez c0bd221
todo comment deleted
jorg3lopez 4ddefce
injectIntoField overloaded method
jorg3lopez ee807ea
injectIntoNonSingleton
jorg3lopez 740f79d
access modifier protected to public
jorg3lopez 006212e
revert access modifier change
jorg3lopez 067eba4
changes:
jorg3lopez 3d9c4f1
Added implementors unit test to ApplicationContextTest
jorg3lopez 19102d8
Merge branch 'main' into use-inject-for-non-singleton-class
luis-pabon-tf be48aed
Merge remote-tracking branch 'refs/remotes/origin/use-inject-for-non-…
jorg3lopez 875b86b
Minor refactoring on some AppContext injection methods
luis-pabon-tf 4adaa27
Make the skip flag on TestApplicationContext switchable from the test…
luis-pabon-tf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiFhirResource.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,25 @@ | ||
package gov.hhs.cdc.trustedintermediary.external.hapi; | ||
|
||
import gov.hhs.cdc.trustedintermediary.context.ApplicationContext; | ||
import gov.hhs.cdc.trustedintermediary.wrappers.HealthData; | ||
import gov.hhs.cdc.trustedintermediary.wrappers.Logger; | ||
import javax.inject.Inject; | ||
import org.hl7.fhir.instance.model.api.IBaseResource; | ||
|
||
/** An implementation of {@link HealthData} to use as a wrapper around HAPI FHIR IBaseResource */ | ||
public class HapiFhirResource implements HealthData<IBaseResource> { | ||
|
||
@Inject private Logger logger; | ||
private final IBaseResource innerResource; | ||
|
||
public HapiFhirResource(IBaseResource innerResource) { | ||
ApplicationContext.injectIntoNonSingleton(this); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To avoid potential issues with circular dependencies and incomplete construction, consider using a factory or builder pattern to manage object creation and dependency injection, rather than injecting dependencies directly in the constructor. [important] |
||
this.innerResource = innerResource; | ||
} | ||
|
||
@Override | ||
public IBaseResource getUnderlyingData() { | ||
this.logger.logDebug("testing @Inject"); | ||
return innerResource; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...src/test/groovy/gov/hhs/cdc/trustedintermediary/external/hapi/HapiFhirResourceTest.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package gov.hhs.cdc.trustedintermediary.external.hapi | ||
|
||
import gov.hhs.cdc.trustedintermediary.context.TestApplicationContext | ||
import gov.hhs.cdc.trustedintermediary.wrappers.Logger | ||
import org.hl7.fhir.r4.model.Bundle | ||
import spock.lang.Specification | ||
|
||
class HapiFhirResourceTest extends Specification { | ||
|
||
def mockLogger = Mock(Logger) | ||
def setup() { | ||
TestApplicationContext.reset() | ||
TestApplicationContext.init() | ||
TestApplicationContext.register(Logger, mockLogger) | ||
} | ||
|
||
def "sample test run to see if logger is injected"() { | ||
given: | ||
def expectedBundle = new Bundle() | ||
when: | ||
def resource = new HapiFhirResource(expectedBundle) | ||
def actualBundle = resource.getUnderlyingData() | ||
then: | ||
expectedBundle == actualBundle | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding specific exception handling for different types of injection failures. This could improve the robustness and security of the application by providing clearer error messages and handling specific cases differently. [important]