Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automated test output on failure #1618

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

basiliskus
Copy link
Contributor

@basiliskus basiliskus commented Nov 26, 2024

Description

Improved logging so we can see the reason for failure in Github when the test fails

Issue

#1527

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

1527 - Fully compliant

Fully compliant requirements:

  • Improve output in gradle/github actions to identify failures without needing to run tests locally.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Incorrect Value
The value 'INCORRECT' in 'OBR-4.3' seems like a placeholder or error. This should be verified if it's intentional or a mistake.

Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Possible issue
Correct the potentially erroneous placeholder value in the test assertion

Ensure that the value for "OBR-4.3" is correctly set according to the expected test
or data schema. The value 'INCORRECT' seems like a placeholder or error.

rs-e2e/src/main/resources/assertion_definitions.json [28]

-"OBR-4.3 = 'INCORRECT'"
+"OBR-4.3 = 'Correct_Value'"
Suggestion importance[1-10]: 8

Why: The suggestion correctly identifies a potential error with the placeholder 'INCORRECT' in a test assertion, which is critical for ensuring the accuracy of test validations. Replacing it with a correct value enhances the test's reliability.

8

Copy link

sonarcloud bot commented Nov 26, 2024

@basiliskus basiliskus marked this pull request as ready for review November 26, 2024 22:42
Copy link
Contributor

@pluckyswan pluckyswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@basiliskus basiliskus merged commit 8435d0b into main Nov 26, 2024
17 checks passed
@basiliskus basiliskus deleted the story/1527/automated-test-output branch November 26, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants