This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
Revert to Java 17 #590
Merged
Revert to Java 17 #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
basiliskus
approved these changes
Oct 20, 2023
jcrichlake
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert to Java 17
Our Staging and Internal environment are failing to handle much of any traffic (it seems to have crashed again since the afternoon). Dev seems unaffected. This seems to originate from Javalin not supporting Loom (virtual threads) fully yet. Dev was on an older commit before Java 21 was being used.
We upgraded to Java 21 earlier this week, and it introduces Loom. Javalin was configured to use these types of threads by default, but Javalin doesn't seem to fully work with them just yet. See javalin/javalin#2011 and javalin/javalin#1778. Javalin, in fact, plans to not use Loom by default in a future release.
I also updated Renovate to stay within Java 17.
Issue
None.