Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This avoids a deprecations warning from Sail #57

Merged
merged 1 commit into from
Jul 2, 2024
Merged

This avoids a deprecations warning from Sail #57

merged 1 commit into from
Jul 2, 2024

Conversation

marnovandermaas
Copy link
Contributor

@marnovandermaas marnovandermaas commented Jul 2, 2024 •
edited
Loading

The warning reads:
Explicit effect annotations are deprecated. They are no longer used and can be removed.

I tested this using the upstream Sail compiler: https://github.com/rems-project/sail/tree/b81e2823f8b4ffcf14cb0b11c260d79d3a19b0dc

@marnovandermaas
This avoids a deprecations warning from Sail
23d95f0 
The warning reads:
Explicit effect annotations are deprecated. They are no longer used and can be removed.
rmn30
rmn30 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@rmn30 rmn30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think I was waiting until we were definitely using a new enough Sail but should be safe now.

@rmn30 rmn30 merged commit 09ef3a7 into CHERIoT-Platform:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmn30 rmn30 rmn30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marnovandermaas @rmn30