Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cheriot is not a CPU name #9

Open
davidchisnall opened this issue Dec 1, 2023 · 3 comments
Open

cheriot is not a CPU name #9

davidchisnall opened this issue Dec 1, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@davidchisnall
Copy link

The back end is currently using CPU == "cheriot" in a few places. We should be looking for Xcheri and Xcheriot so that eventually we can look for Zcheri and Xcheriotv{version number}.

@davidchisnall davidchisnall added the good first issue Good for newcomers label Dec 1, 2023
@v01dXYZ
Copy link

v01dXYZ commented Nov 6, 2024

Hello,

I'm a junior dev which tries to learn about compilers. I'm interested into contributing to your LLVM fork as contributing to LLVM directly requires quite a lot of patience and I think it would be easier for me if I receive feedback more frequently.

Is this issue still relevant ?

@davidchisnall
Copy link
Author

Hi! It is, but @resistor is currently in the process of updating from LLVM 13 to 17, which will touch a lot of this code and would cause some merge pain for you. I think #34 might be easy to do and then rebase on the new branch, if you're interested in working on clang, as might #4. Alternatively, I hope the merge to 17 will be done soon and then this should be a good first issue.

@resistor
Copy link
Collaborator

@v01dXYZ I have a patch queued up for after LLVM 17 lands, which will add "riscv32cheriot" as a sub-architecture to the TargetTriple. Once that's in, we should migrate most or all of the instances of CPU == "cheriot' to check the sub-architecture of the triple instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants