Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maximum lifetime for a GitHub runner #4

Open
bbockelm opened this issue Oct 8, 2023 · 0 comments
Open

Set maximum lifetime for a GitHub runner #4

bbockelm opened this issue Oct 8, 2023 · 0 comments

Comments

@bbockelm
Copy link
Collaborator

bbockelm commented Oct 8, 2023

The service node should initiate the shutdown of idle GitHub runners that have already run for some pre-configured threshold (suggestion: 4 hours).

By turning over these runners, we will ensure others get the opportunity to grab the slots in the pool.

Notes:

  • Only remove runners that are idle. Don't worry about race conditions: requests to remove a runner that just picked up a new action are ignored.
  • Only way to gracefully shutdown runners is by removing the runner via the GitHub API. If Remove VMs that fail to connect to GitHub #3 is implemented, we should set an attribute in the job ad that states when the graceful shutdown was initiated to avoid the cleanup script initiating a hard-shutdown of a VM that's doing a graceful shutdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant