You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be helpful, both for purposes of documentation as well as for good code practice to introduce formal tests for all of the expected outputs of the naming capability (i.e., pytest).
Tests should demonstrate proper output control for situations in each of the following output folders:
Finally, testing should confirm the capability to check or not check the validity of the generated urls, with some documentation about the corner cases involved with checking and additional documentation about the input command-line options for that.
The text was updated successfully, but these errors were encountered:
jameshalgren
changed the title
Add test for all potential outputs of naming
Add tests for all potential outputs of naming
Oct 12, 2023
It would be helpful, both for purposes of documentation as well as for good code practice to introduce formal tests for all of the expected outputs of the naming capability (i.e., pytest).
Tests should demonstrate proper output control for situations in each of the following output folders:
Similarly, tests should show the capability to provide the output for the different base urls
'''
0: "",
1: "https://nomads.ncep.noaa.gov/pub/data/nccf/com/nwm/prod/",
2: [DO NOT USE] "https://nomads.ncep.noaa.gov/pub/data/nccf/com/nwm/post-processed/WMS/",
3: "https://storage.googleapis.com/national-water-model/",
4: "https://storage.cloud.google.com/national-water-model/",
5: "gs://national-water-model/",
6: "gcs://national-water-model/",
7: "https://noaa-nwm-pds.s3.amazonaws.com/",
8: "https://ciroh-nwm-zarr-copy.s3.amazonaws.com/national-water-model/",
'''
Finally, testing should confirm the capability to check or not check the validity of the generated urls, with some documentation about the corner cases involved with checking and additional documentation about the input command-line options for that.
The text was updated successfully, but these errors were encountered: