Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for all potential outputs of naming #6

Open
61 tasks
jameshalgren opened this issue Oct 11, 2023 · 2 comments
Open
61 tasks

Add tests for all potential outputs of naming #6

jameshalgren opened this issue Oct 11, 2023 · 2 comments

Comments

@jameshalgren
Copy link
Member

jameshalgren commented Oct 11, 2023

It would be helpful, both for purposes of documentation as well as for good code practice to introduce formal tests for all of the expected outputs of the naming capability (i.e., pytest).

Tests should demonstrate proper output control for situations in each of the following output folders:

  • analysis_assim
  • analysis_assim_alaska
  • analysis_assim_alaska_no_da
  • analysis_assim_coastal_atlgulf
  • analysis_assim_coastal_hawaii
  • analysis_assim_coastal_pacific
  • analysis_assim_coastal_puertorico
  • analysis_assim_extend
  • analysis_assim_extend_alaska
  • analysis_assim_extend_alaska_no_da
  • analysis_assim_extend_coastal_atlgulf
  • analysis_assim_extend_coastal_pacific
  • analysis_assim_extend_no_da
  • analysis_assim_hawaii
  • analysis_assim_hawaii_no_da
  • analysis_assim_long
  • analysis_assim_long_no_da
  • analysis_assim_no_da
  • analysis_assim_puertorico
  • analysis_assim_puertorico_no_da
  • forcing_analysis_assim
  • forcing_analysis_assim_alaska
  • forcing_analysis_assim_extend
  • forcing_analysis_assim_extend_alaska
  • forcing_analysis_assim_hawaii
  • forcing_analysis_assim_puertorico
  • forcing_medium_range
  • forcing_medium_range_alaska
  • forcing_medium_range_blend
  • forcing_medium_range_blend_alaska
  • forcing_short_range
  • forcing_short_range_alaska
  • forcing_short_range_hawaii
  • forcing_short_range_puertorico
  • long_range_mem1
  • long_range_mem2
  • long_range_mem3
  • long_range_mem4
  • medium_range_alaska_mem1
  • medium_range_alaska_mem2
  • medium_range_alaska_mem3
  • medium_range_alaska_mem4
  • medium_range_alaska_mem5
  • medium_range_alaska_mem6
  • medium_range_alaska_no_da
  • medium_range_blend
  • medium_range_blend_alaska
  • medium_range_blend_coastal_atlgulf
  • medium_range_blend_coastal_pacific
  • medium_range_coastal_atlgulf_mem1
  • short_range
  • short_range_alaska
  • short_range_coastal_atlgulf
  • short_range_coastal_hawaii
  • short_range_coastal_pacific
  • short_range_coastal_puertorico
  • short_range_hawaii
  • short_range_hawaii_no_da
  • short_range_puertorico
  • short_range_puertorico_no_da
  • usgs_timeslices

Similarly, tests should show the capability to provide the output for the different base urls
'''
0: "",
1: "https://nomads.ncep.noaa.gov/pub/data/nccf/com/nwm/prod/",
2: [DO NOT USE] "https://nomads.ncep.noaa.gov/pub/data/nccf/com/nwm/post-processed/WMS/",
3: "https://storage.googleapis.com/national-water-model/",
4: "https://storage.cloud.google.com/national-water-model/",
5: "gs://national-water-model/",
6: "gcs://national-water-model/",
7: "https://noaa-nwm-pds.s3.amazonaws.com/",
8: "https://ciroh-nwm-zarr-copy.s3.amazonaws.com/national-water-model/",
'''

Finally, testing should confirm the capability to check or not check the validity of the generated urls, with some documentation about the corner cases involved with checking and additional documentation about the input command-line options for that.

@jameshalgren jameshalgren changed the title Add test for all potential outputs of naming Add tests for all potential outputs of naming Oct 12, 2023
@jameshalgren
Copy link
Member Author

jameshalgren commented Oct 16, 2023

@RohanSunkarapalli @manjirigunaji
Please bring AlabamaWaterInstitute/data_access_examples#65 over to this repository.

@jameshalgren
Copy link
Member Author

@RohanSunkarapalli @manjirigunaji
Will you check off the tests that have been added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant