Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in src/socket.io/admin/rooms.js to reduce cognitive complexity #74

Open
jwjulie opened this issue Jan 22, 2025 · 2 comments · May be fixed by #105
Open

Refactoring code in src/socket.io/admin/rooms.js to reduce cognitive complexity #74

jwjulie opened this issue Jan 22, 2025 · 2 comments · May be fixed by #105
Assignees
@jwjulie

Comments

@jwjulie
Copy link

jwjulie commented Jan 22, 2025

Cognitive complexity of src/socket.io/admin/rooms.js needs to be reduced from 16 to at most 15. Starting from line 34, there are multiple levels of nesting, loops, and conditionals, making it harder to understand the code.
@jwjulie
Copy link
Author

jwjulie commented Jan 22, 2025

I would like to work on this please!

@github-actions GitHub Actions
Copy link

Great! I assigned you (@jwjulie) to the issue. Have fun working on it!

@jwjulie jwjulie linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwjulie jwjulie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored src/socket.io/admin/rooms.js to reduce cognitive complexity jwjulie/NodeBB
1 participant
@jwjulie