Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert src/posts/bookmarks.js from JS to TS #73

Closed
wants to merge 2 commits into from
Closed

Convert src/posts/bookmarks.js from JS to TS #73

wants to merge 2 commits into from

Conversation

azhang49
Copy link

  • Created new file src/posts/bookmarks.ts as a copy of src/posts/bookmarks.js
  • Added eslint disabling comments for calls to external JavaScript files which have not yet been translated
  • Reformatted imports
  • Typed function inputs and outputs

Resolves #28

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7616594237

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.096%
Totals Coverage Status
Change from base Build 6014654874: 0.1%
Covered Lines: 22634
Relevant Lines: 25362
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Converting src/posts/bookmarks.js from JS to TS
3 participants
@azhang49 @coveralls @rohanpadhye