forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsAnswered checkbox frontend attempt #30
Open
VeronicaPim
wants to merge
22
commits into
f24
Choose a base branch
from
failing-frontend
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added one emoji reaction - primitive start
Added anonymous checkbox to the UI
eunseokk
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says there are some issues with the redis-server? If you want to check on that!
VeronicaPim
changed the title
Failing frontend **EDIT THIS**
IsAnswered checkbox frontend attempt
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Composer UI Updates & Frontend Testing for NodeBB
Summary
This PR attempts to solve issue #13 and includes a significant update to the composer.tpl file within NodeBB’s frontend, aimed at improving the layout and functionality of the composer section where users create and edit posts. Additionally, this PR includes initial work on frontend testing for the composer component. However, after making these changes, NodeBB encountered severe issues during startup, which are currently being troubleshooted. Despite multiple attempts to resolve the issue, including consulting with a TA during office hours, the problem persists.
Key Changes:
Composer.tpl File Edits:
src/views/partials/chats/composer.tpl
Frontend Testing for Composer Component:
Challenges Encountered:
NodeBB Failing to Start:
Failed to fetch
errors related to theservice-worker.js
file, as well as multiple network request failures forservice_worker.js
andinstaller.min.js
.Redis-Server Potential Issue:
Current Status:
Steps Taken for Troubleshooting (Ongoing):
composer.tpl
: Verified that no syntax errors or unclosed tags were causing the issue../nodebb log
and./nodebb dev
to examine logs, revealing service worker and fetch errors../nodebb reset -p
), but this did not resolve the issue.node_modules
to rule out corrupted dependencies, with no success.Next Steps for Debugging:
To Reviewers:
composer.tpl
file and the addition of frontend testing for the composer UI.Testing Instructions (When NodeBB is Running):
failing-frontend
branch.npm install
and then start NodeBB (./nodebb start
or./nodebb dev
).