Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator Merging #39

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Translator Merging #39

merged 8 commits into from
Nov 13, 2024

Conversation

eunseokk
Copy link

Merging the commits I made to update the back-end of the translator initial codes.

Commit being added: CMU-313/NodeBB@f24...f24-p4
Issues: Need to now integrate with frontend code.

@VeronicaPim VeronicaPim self-requested a review November 13, 2024 21:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11827207132

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 82.667%

Files with Coverage Reduction New Missed Lines %
src/notifications.js 1 79.27%
Totals Coverage Status
Change from base Build 11805088855: 0.001%
Covered Lines: 22332
Relevant Lines: 25593

💛 - Coveralls

@ericlin2 ericlin2 self-requested a review November 13, 2024 23:00
@ericlin2
Copy link

looks good to me

@ericlin2 ericlin2 merged commit 84a641c into f24 Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants