forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymous attribute handing in Post API #35
Open
mhli1260
wants to merge
16
commits into
f24
Choose a base branch
from
mia-user_anonymous_togglebutton
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he if statement to make sure button is actually on
jullia02
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code looks good, I'm not sure where it fails though. Maybe you could try updating the schema for topics?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to solve issue #11 : Read issue description for my full attempt at solving it/explanation at why it's incomplete.
Adds an anonymous attribute (takes the value of 0 if button is off and 1 if button is on) to the api for posts, so I will be able to access the state of the anonymous toggle button (on/off) when updating the username and displayname for a post to "anonymous". Can manually test changes by going to route: '/api/v3/posts/{pid}'. Default value for the anonymous attribute is 0.
Automated test cases I added: in test/api.js => the tests check to make sure that responses to get calls for posts return an API with an anonymous attribute
Frontend tests: Can't really make frontend test cases (confirmed by TA at OH), but using our teams frontend repo, if you try to make a post, you should be able to see a toggle button with "Anonymous" next to it before submitting the post.
The 2 failing test cases: these are a result of my incomplete feature. I updated the api for posts to include an anonymous attribute, but could not properly update the post schema within the allotted time for the sprint.
Here were my attempts to properly update the post schema: