Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous attribute handing in Post API #35

Open
wants to merge 16 commits into
base: f24
Choose a base branch
from

Conversation

mhli1260
Copy link

@mhli1260 mhli1260 commented Oct 10, 2024

Attempts to solve issue #11 : Read issue description for my full attempt at solving it/explanation at why it's incomplete.

Adds an anonymous attribute (takes the value of 0 if button is off and 1 if button is on) to the api for posts, so I will be able to access the state of the anonymous toggle button (on/off) when updating the username and displayname for a post to "anonymous". Can manually test changes by going to route: '/api/v3/posts/{pid}'. Default value for the anonymous attribute is 0.

Automated test cases I added: in test/api.js => the tests check to make sure that responses to get calls for posts return an API with an anonymous attribute

Frontend tests: Can't really make frontend test cases (confirmed by TA at OH), but using our teams frontend repo, if you try to make a post, you should be able to see a toggle button with "Anonymous" next to it before submitting the post.

The 2 failing test cases: these are a result of my incomplete feature. I updated the api for posts to include an anonymous attribute, but could not properly update the post schema within the allotted time for the sprint.
Here were my attempts to properly update the post schema:

  • add the anonymous feature (type: number) to the schema in public/openapi/write/posts/pid.yaml
  • add the anonymous feature (type: number) to the schema in public/openapi/components/schemas/PostObject.yaml
  • also attempted adding the feature to TopicObject.yaml file and tid.yaml, but none of these attempts were successfully updating the returned schema in test/api.js
  • attempted to debug the comparison of response and schema in test.api using console.log statements

Copy link

@jullia02 jullia02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code looks good, I'm not sure where it fails though. Maybe you could try updating the schema for topics?

@jullia02 jullia02 added this to the Sprint 2 milestone Oct 10, 2024
@jullia02 jullia02 added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If toggle button for anonymity is on, upload post with anonymous tag and default profile.
2 participants