Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes from project 1B: refactored deserialize() to reduce cognitive… #27

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

veronicabenedict
Copy link

Adding changes to meta/configs.js from project 1B.

This change refactors the deserialize() function in order to reduce the cognitive complexity by using added helper functions.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11020980135

Details

  • 14 of 17 (82.35%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 82.684%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/meta/configs.js 14 17 82.35%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10969298942: 0.008%
Covered Lines: 22343
Relevant Lines: 25600

💛 - Coveralls

@etong11 etong11 merged commit 1369d72 into f24 Sep 24, 2024
1 check passed
@etong11 etong11 requested review from etong11 and removed request for etong11 September 24, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants