Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4 checkpoint2 #55

Merged
merged 9 commits into from
Nov 13, 2024
Merged

P4 checkpoint2 #55

merged 9 commits into from
Nov 13, 2024

Conversation

ldlin1
Copy link

@ldlin1 ldlin1 commented Nov 13, 2024

These are changes that are suggested in the translator-service repo README.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11826612056

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 82.688%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11487961485: -0.002%
Covered Lines: 22388
Relevant Lines: 25650

💛 - Coveralls

@etong11
Copy link

etong11 commented Nov 13, 2024

Fixed lint issues and changed the API endpoint for OpenAI to our team's endpoint.

To pass the tests, had to add isEnglish to post schema and add translatedContent as well as an additionalProperty if the tests failed due to the response not having translatedContent.

@etong11 etong11 merged commit 07f7e5e into f24 Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants