Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Integrate Translator Service #52

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

ay0503
Copy link

@ay0503 ay0503 commented Nov 13, 2024

Added code to let the client request make a REST API request to the translator service.

@ay0503 ay0503 self-assigned this Nov 13, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11812040469

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 82.671%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11621109368: 0.0%
Covered Lines: 22332
Relevant Lines: 25592

💛 - Coveralls

Copy link

@lexik04 lexik04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me!

Copy link

@KevnKey KevnKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great overall, the separate folder for translate definitely keeps the modularity

var isVisible = $(this).closest('.sensitive-content-message').next('.translated-content').is(':visible');
if (isVisible) {
$(this).text('Hide the translated message.');
} else {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it shows the translated message without hiding the original, seems like a good way to do it

Copy link

@vsolskyyy vsolskyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well organized changes and code. Maybe you could add comments to explain the code, but otherwise good job.

@ay0503 ay0503 merged commit ed824a1 into f24 Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants