Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros to Bnyahaj contains extraneous debug topics #90

Open
mehulgoel873 opened this issue May 15, 2024 · 0 comments
Open

Ros to Bnyahaj contains extraneous debug topics #90

mehulgoel873 opened this issue May 15, 2024 · 0 comments
Labels
question Further information is requested

Comments

@mehulgoel873
Copy link
Collaborator

The current code includes publishers for a large amount of debug topics, that don't actually exist for NAND (Should be fact checked, but I don't believe they exist)

Thus, these may not be accurately logged for NAND and could cause potential issues. Ideally both SC and NAND should have feature parity on Debug topics, and if not possible, we should make sure that NAND does not break this

The following code in ros_to_bnyahaj.py (within init):

self.rc_steering_angle_publisher = rospy.Publisher(self_name + "/buggy/debug/rc_steering_angle", Float64, queue_size=1)
self.steering_angle_publisher = rospy.Publisher(self_name + "/buggy/debug/steering_angle", Float64, queue_size=1)
self.battery_voltage_publisher = rospy.Publisher(self_name + "/buggy/debug/battery_voltage", Float64, queue_size=1)
self.operator_ready_publisher = rospy.Publisher(self_name + "/buggy/debug/operator_ready", Bool, queue_size=1)
self.steering_alarm_publisher = rospy.Publisher(self_name + "/buggy/debug/steering_alarm", Bool, queue_size=1)
self.brake_status_publisher = rospy.Publisher(self_name + "/buggy/debug/brake_status", Bool, queue_size=1)
self.use_auton_steer_publisher = rospy.Publisher(self_name + "/buggy/debug/use_auton_steer", Bool, queue_size=1)
self.rc_uplink_qual_publisher = rospy.Publisher(self_name + "/buggy/debug/rc_uplink_quality", UInt8, queue_size=1)
self.nand_fix_publisher = rospy.Publisher(self_name + "/buggy/debug/nand_fix", UInt8, queue_size=1)
@mehulgoel873 mehulgoel873 added the question Further information is requested label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant