Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros to Bnayahj NAND Telemetry #91

Open
mehulgoel873 opened this issue May 15, 2024 · 1 comment
Open

Ros to Bnayahj NAND Telemetry #91

mehulgoel873 opened this issue May 15, 2024 · 1 comment
Labels
jank Spaghetti code that should be updated

Comments

@mehulgoel873
Copy link
Collaborator

Right now, NAND Telemetry is pretty scuffed, and needs to be properly communicated with firmware.

Currently, only passed in velocity as a singular value, which means that the twist is impossible to calculate, and should be done properly.
Additionally, heading calculations needs to be double checked.

Overall, this change has not been mock rolled and not stable, although it is on the main branch.

Suspicious code:

speed = packet.velocity
# TODO: fix this
# why this works: autonsystem only cares about magnitude of velocity
# so setting an arbitrary axis to the speed and leave other at 0
# works. However, this should be done properly ASAP
odom.twist.twist.linear.x = speed
@mehulgoel873
Copy link
Collaborator Author

This is for ros_to_bnyahaj.py

@mehulgoel873 mehulgoel873 added the jank Spaghetti code that should be updated label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jank Spaghetti code that should be updated
Projects
None yet
Development

No branches or pull requests

1 participant