Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized after trying to install from the build wheel for 0.10.0 (that I also pushed to pypi 🤦) that things weren't quite right. It didn't really seem to be installing
serpentTools
package, but each individual sub-package (e.g.,data
.,io
) so you couldn't really doimport serpentTools
.After an hour of fighting w/ the flat-style layout and
setuptools
, I decided the easier fix was just togit mv serpentTools src/serpentTools
. So while there are lots of changed files, the real changes are specific toMANIFEST.in
pyproject.toml
docs/examples/nodal_writer.py
:: previously broken symlinkI've done more testing on the wheel built from this version, and it looks much better. Gives us the versions we want, in the layout we expect, with the modules we want.
After this goes through, we should do the following
0.10.1
0.10.1
wheel to pypi (later we can automate this CI Auto-deploy wheel and source distribution to pypi on release #505)0.10.0
from pypi so that no one gets version0.10.0
withpip install serpentTools
0.10.1
and other0.10.*
later, just not literally0.10.0
I should have caught this sooner. The jupyter issue in testing (#493) should have tipped me off to this install problem