Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Fix install with src layout #506

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

drewejohnson
Copy link
Collaborator

Realized after trying to install from the build wheel for 0.10.0 (that I also pushed to pypi 🤦) that things weren't quite right. It didn't really seem to be installing serpentTools package, but each individual sub-package (e.g., data., io) so you couldn't really do import serpentTools.

After an hour of fighting w/ the flat-style layout and setuptools, I decided the easier fix was just to git mv serpentTools src/serpentTools. So while there are lots of changed files, the real changes are specific to

  • MANIFEST.in
  • pyproject.toml
  • docs/examples/nodal_writer.py :: previously broken symlink

I've done more testing on the wheel built from this version, and it looks much better. Gives us the versions we want, in the layout we expect, with the modules we want.

After this goes through, we should do the following

  1. Make a new tag + release for 0.10.1
  2. Push 0.10.1 wheel to pypi (later we can automate this CI Auto-deploy wheel and source distribution to pypi on release #505)
  3. "yank" release 0.10.0 from pypi so that no one gets version 0.10.0 with pip install serpentTools
    • They will still get 0.10.1 and other 0.10.* later, just not literally 0.10.0

I should have caught this sooner. The jupyter issue in testing (#493) should have tipped me off to this install problem

@drewejohnson
Copy link
Collaborator Author

@DanKotlyar can you "yank" release 0.10.0 from pypi?

I do not have this ability

@DanKotlyar
Copy link
Contributor

@drewejohnson Can you provide more details on how to "yank"?
I understand why "yanking" is needed but couldn't understand what exactly should I do.

@drewejohnson
Copy link
Collaborator Author

Yeah there don't appear to be any documentation for it. Looks like the steps are

  1. Log in to pypi.org
  2. Go to "Your projects" from top right profile or https://pypi.org/manage/projects/
  3. Select "Manage" option for serpent tools
  4. There you should see all the releases that have been made
  5. Select "Options" for release 0.10.0
  6. Select "Yank"

We can also merge this and I'll work on 0.11.0 release notes that include this MR

@drewejohnson drewejohnson self-assigned this Aug 22, 2023
@DanKotlyar DanKotlyar merged commit e2822da into CORE-GATECH-GROUP:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants