Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Feedback #14

Open
PHenegan opened this issue May 31, 2023 · 0 comments
Open

Design Feedback #14

PHenegan opened this issue May 31, 2023 · 0 comments

Comments

@PHenegan
Copy link

Your design and Github issues are generally good, but here's some feedback:

  • You should probably incorporate having a class and an interface for different classes in your project (specificallly, for the MVC related objects)
  • It's also worth noting that the controller should have a model, and not the other way around, because the controller is responsible for the logical flow of the game (coordinating between the two players and updating them after each turn
  • Its also worth thinking about how the manual player will get its inputs. We discussed this a bit in lab today with the proxy pattern and dependency injection.
  • you may want to add some more specific details to your issues to make it clearer how everything will fit together when you implement it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant