Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
* remove unused files * set up nextjs base files * remove unused logo and image files, install daisyui dependency
* remove unused files * set up nextjs base files * remove unused logo and image files, install daisyui dependency * setup initial code architecture * add scripts directory
* Replace daisyUI with NextUI - add dummy backend - rename peerprep folder to frontend * Add support for delete question action * Add entry point for questions page * Move question page to page folder - change question interface to types - handle exceptions for api calls
Create logo component
Create Pull Request Template
* Add modal ui for creating questions - move `QuestionTable` component to question subfolder * Add frontend impl of question CRUD - move question type to frontend type folder - add prettier support * Add page to display question description * Update endpoint.ts * Update question related file structure - rename api.ts to services.ts and move to helper folder - add complexity chip component for rendering complexity levels - remove middleware.ts - update references
…page-and-user-profile Create sign-in/sign-up page and user page
* feat: create navbar component (no backend) * fix: remove navbar max width * feat: landing page with mock auth service for conditional rendering * feat: general layout of dashboard * feat: frontend card for matching with dummy backend * fix: remove width limit for matching dropdowns * build: install d3 package for chart visualisation * refactor: change matching dropdown options to reflect types * feat: donut chart for complexity statistics refactor: organise components by pages * refactor: extract button handlers for easier modification perf: set dashboard cards to scroll upon overflow * fix: remove scroll for cards in dashboard because do not want visible scrollbars * feat: quick match button * refactor: specify service in api wrapper file names * perf: update navbar design * perf: edit dropdown menu text
* create user service with postgresql database, database setup with prisma, API is working :) * add more properties for user such as bio and gender, check no extra request body is given in order to get successful response * update database date properties to standardize the naming, create a new get user by email endpoint that supports finding user by email * do some refactors, fix bugs for multiple endpoints * create some unit tests for endpoint behaviours * create a very simple integration test * create a simple readme * create a simple readme for api docs * add more unit tests for the case when there are duplicated emails * do a bit of restructuring for better consistency * add new get, post and put endpoints to support user preferences, current db implementation is multi-value fields, fix bugs in topic enum convert function * update readme for new preferences endpoints
* create initial question API with simple logics, without database * add more checks for post and put handlers * add todo comments for database integration, support filter query param for getQuestions * created simple test skeleton * update topic enums, added questions in json format * added crud for mongodb --------- Co-authored-by: tryyang2001 <[email protected]> Co-authored-by: Xing Jie <[email protected]>
bug fix for gender converter function
* flatten getQuestionById response data, make enum checking case insensitive, update pkg.json for mongodb dependency, fix typo in questions.json data * use mongoose to interact with mongodb, add additional check to prevent duplicated topics provided, fixed minor bugs in enum and zod validators
* Add support to retrieve and create questions - Add support to examples and constrains in create question modal. - Impl common endpoint return interface to support standardization of wrapper layer. * Add support to update and delete questions - change wrapper-functions to server actions. - clear cache after each api call. * Add DeleteQuestion component - disable id input field - add support for error formatting * Adjust table width * Add support for rich text editor - remove tooltips for delete button * Remove logging
tryyang2001
temporarily deployed
to
development
GitHub Actions
Inactive
* fix: wrong regex for input parsing * fix: remove trim on input for testcases * perf: make input guidelines clearer * style: standardise card bg in account related ui * perf: input in console should be language speciifc * fix: string outputs do not have quotes * fix: text overflow in results panel * style: change exclamation icon * fix: remove unnecessary console logs * fix: fe build
* finalize as3 * fix readme deployment for local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mastersince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @tryyang2001 @c0j0s @xingjie99 @weidak @tlyi