Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug "Too much recursion" #9

Open
McGiogen opened this issue Jun 13, 2016 · 0 comments
Open

Bug "Too much recursion" #9

McGiogen opened this issue Jun 13, 2016 · 0 comments

Comments

@McGiogen
Copy link

There is a bug caused by a weak check using recursion to list all child forms errors in the same form-errors panel.
We have encountered this because of angular-xeditable but I'm sure it's not the only case that can occur.
The problem is simple: this directive search child forms between props not starting with dollar "$", but xeditable put some internal props starting with "_" which breaks the recursion. To solve this problem I've made a fork checking if the value of the property is an object before recursing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant