Skip to content
This repository has been archived by the owner on Aug 10, 2021. It is now read-only.

Reimplement a location picker #1

Open
paride opened this issue Mar 15, 2017 · 1 comment
Open

Reimplement a location picker #1

paride opened this issue Mar 15, 2017 · 1 comment

Comments

@paride
Copy link
Member

paride commented Mar 15, 2017

Signal's location picker relies on the proprietary Play Services and has been removed from Cable. The feature is missing and has to be re-implemented using free libraries, possibly using OpenStreeMap. Useful notes:

  • The location code has not been removed, but commented out, adding the Location-TODO string to the comment, so it's easy to find where the relevant code is. The three files SignalMapView.java, SignalPlace.java, LocationSlide.java, have been renamed to .java.nogms.
  • The location picker should not rely on OsmAnd (or any other app) being installed.
  • The URL has to be shared using standard geo: URIs.
  • A linkifier for geo: URIs has to be added (a PR implementing this has been submitted to Signal, but it has been rejected, see below).

Relevant Signal issues and PR:

@paride paride changed the title Remplement a location picker Reimplement a location picker Mar 21, 2017
@paride
Copy link
Member Author

paride commented Jul 26, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant