Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add year cycle for Tibetan and some Hindu calendars? #28

Open
eroux opened this issue Jul 14, 2021 · 2 comments
Open

add year cycle for Tibetan and some Hindu calendars? #28

eroux opened this issue Jul 14, 2021 · 2 comments

Comments

@eroux
Copy link
Contributor

eroux commented Jul 14, 2021

I just need to clarify something before making a proposal: at some point we discussed the idea of encoding the year cycle number in #9 but in this issue we decided that these can be encoded as eras (to which we can give codes). Now, in a meeting (can't remember which one but it was the one where the issues I brought up were discussed, a few months ago), we decided something else: that there should be a new integer field named "year cycle number". I'm not really sure where to find the meeting notes, and I think both solutions are ok (although I have a preference for the second one which is more flexible), but I just want to make sure I'm not doing something against the decision rules if I propose a change. @ronaldtse wdyt?

@ronaldtse
Copy link
Contributor

ronaldtse commented Jul 14, 2021

Since there was already consensus that this problem needs to be addressed, please feel free to implement the preferred change.

@eroux
Copy link
Contributor Author

eroux commented Jul 14, 2021

ok thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants