-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-local scoping #138
Open
BobVarioa
wants to merge
45
commits into
CanadaHonk:main
Choose a base branch
from
BobVarioa:scopes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CanadaHonk
reviewed
Jul 26, 2024
|
related to the previous merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently:
this
andnew.target
are not supported in this PR.var
andthis
semantics #107globalThis
#108this.x++
const
is now actually different fromlet
var/let a = () => ...
hack (except for test262),const a = () => ...
is still optimized howeverCaveats:
delete
for variables and builtin vars, which already had limited supportAlso, this is a somewhat broken implementation, but for good reasons in my opinion. For example, take this:
And well, that's not how that is supposed to work at all, but adding that requires runtime allocation, and binding certain values to functions. I will follow up this PR implementing them both, but I felt that they were somewhat out of scope of this PR.
To do:
var
s out of nested scopes