Improve command line interface #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobVarioa
suggested changes
Aug 12, 2024
compiler/prefs.js
Outdated
| help: 1 | ||
| }, | ||
| { | ||
| arg: 'help-hidden', |
There was a problem hiding this comment.
Yeah, also a good idea.
compiler/prefs.js
Outdated
|
|
||
| for (const x of process.argv) { | ||
| if (x[0] !== '-') continue; | ||
| export function parseArgs(argv, optionsOnly = false, file) { |
There was a problem hiding this comment.
Usually Porffor uses the export const parseArgs = (...) => ... format, not function
There was a problem hiding this comment.
Okay, I guess a simple change.
runner/repl.js
Outdated
| globalThis.valtype = Options.valtype ?? 'f64'; | ||
|
|
||
| const color = (txt, colors) => { | ||
| if (!(process.stdout.isTTY ?? true)) { |
There was a problem hiding this comment.
Doesn't this require changes to index.html's setProcess method?
There was a problem hiding this comment.
Well, I have a better version in prefs.js but I don't think repl gets used within the website?
There was a problem hiding this comment.
Ah, you're right, I misread which file this was in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-writes the command line parser (prefs.js) and adds a more helpful help message. Prefs is also renamed to Options, mostly so that I could make sure that nobody was using Prefs anymore. The help message is currently very unorganized and many options that should be invisible by default aren't - however this is easy to fix by shuffling around a few elements and adding a few
hide: trues and a few{ separator: '...' }s.