Multi-value transition #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `generate` function is used to generate wasm that always returns both `f64` and `i32`.
I know this isn't really related to the multi-value transition stuff but it removes most timeouts and makes test262 viable on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request transitions to a new system for
generatewhere the wasm always returns both anf64and ani32. This replaces the existing system where anf64was sometimes returned from the wasm ofgenerateandgetNodeTypewas used to get the type. In the future, this aims to makegetNodeType,dropLeftoverredundant and put values and types closer together. However, the old system is not completely replaced because that would make this pull request much larger. Instead,generateLegacyexists that can generate code with the old behavior. Because of this, the first commit mostly consists of replacements fromgeneratetogenerateLegacyin old code. Therefore, I recommend primarily looking at the remaining commits.