Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

fix slideshow bug, initialized slides after the content is loaded #430

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

aguyran
Copy link
Contributor

@aguyran aguyran commented Oct 4, 2021

Issue that this pull request solves

Closes: #428

Proposed changes

Brief description of what is fixed or changed

Assigned a empty this.deck and initialized with new Reveal object every time ngAfterView triggers, so it assigns relevant classes after every render

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@goliakshay357
Copy link
Member

Hello @aguyran,
LGTM!!. Feel free to check #431 #432

Thanks for the update :)

@goliakshay357 goliakshay357 merged commit 85dadd4 into Canvasbird:master Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slides Wont show up few a times
2 participants