Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt background sound volume based on video volume #93

Open
3 tasks
Betree opened this issue Apr 1, 2019 · 3 comments
Open
3 tasks

Adapt background sound volume based on video volume #93

Betree opened this issue Apr 1, 2019 · 3 comments
Labels
bounty This issue has a bounty attached bounty > 30€ complexity > simple Simple tasks (usually a few hours) frontend Everything for https://github.com/CaptainFact/captain-fact-frontend good first issue Good for newcomers

Comments

@Betree
Copy link
Member

Betree commented Apr 1, 2019 •
edited
Loading

We should retrieve the volume from ReactPlayer and adapt background notifications volume accordingly. As of today the volume can be too strong or too low.

  • Store the volume from ReactPlayer in redux state
  • Retrieve the value in app/components/App/BackgroundNotifier.jsx
  • Set audiofile.volume = ___ for all notifications types (refute/confirm/neutral)
@Betree Betree added frontend Everything for https://github.com/CaptainFact/captain-fact-frontend complexity > simple Simple tasks (usually a few hours) bounty This issue has a bounty attached bounty > 20€ labels Apr 1, 2019
@Betree
Copy link
Member Author

Betree commented Apr 1, 2019 •
edited
Loading

💸 A 30€ bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with 30€ when the Pull Request is reviewed, accepted and merged. More info.

@Betree Betree added good first issue Good for newcomers priority This issue should be treated first bounty > 30€ and removed bounty > 20€ labels Apr 1, 2019
@Miragide
Copy link
Contributor

@Betree maybe should you give more explanation of this issue?

@Betree Betree removed the priority This issue should be treated first label Feb 23, 2020
@Betree
Copy link
Member Author

Betree commented Feb 23, 2020

If your computer volume is 100% and you put the video's volume at 10%, the notifications will keep popping loud. The idea is to synchronize the volume of notifications with what you put in the player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty This issue has a bounty attached bounty > 30€ complexity > simple Simple tasks (usually a few hours) frontend Everything for https://github.com/CaptainFact/captain-fact-frontend good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Betree @Miragide