Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code loading still has problems #18

Open
eugle opened this issue Jan 28, 2021 · 1 comment
Open

Code loading still has problems #18

eugle opened this issue Jan 28, 2021 · 1 comment

Comments

@eugle
Copy link

eugle commented Jan 28, 2021

First of all, I have been using this package, but recently, when I double-checked to optimize the loading speed, I found that it will load some files that are not needed by the current path, and these files will cause the loaded files to become larger, which will reduce the loading speed.

This question should have been raised by others, but I found that you seem to have overlooked it, but it really exists

First of all, after I used your package, I compared it with @loadable/components. The same code, but the package used is different, you will find that using your package will load more files

However, @loadable/components has a problem and cannot be used in meteor, because enabling ssr requires configuring webpack, and there is no way to do this in meteor

Therefore, when using @loadable/components, ssr is not enabled, but code splitting is implemented. I don't know if it is because of this that it is different from your package

But the final effect is to achieve and use @loadable/components, only load the components and files contained in the current path, and don’t load the unused ones.

haven’t updated this package for nearly half a year. When can upgrade to the 1.0.1 official version?

You are quick to come back

I am very sorry, my technical level is too poor and I cannot participate in the development of this package by myself. If I can, I would like to add these functions by myself. However, I haven’t understood these principles yet.

I wish you all the best in 2021 and happy every day

@CaptainN
Copy link
Owner

CaptainN commented Jan 28, 2021

I'd love to know more, but I need a reproduction to check it out. From all my own testing, it really should only be loading assets it records on the SSR pass. This is quite a manual process to set up ATM, so you should be able to see the list of modules it loads in the SSR out put. Do you see additional modules getting loaded that are not in that list?

BTW, there haven't been updates because this is shelf-stable. Unless there is a demonstrate bug to fix, there's no reason to make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants