From 72a2acaa2180fe0a374f2c968cec0c0136b8af9c Mon Sep 17 00:00:00 2001 From: Jon Uhlmann Date: Sun, 22 Nov 2020 22:41:26 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=A5=20Remove=20default=20`type=3D"text?= =?UTF-8?q?/javascript"`=20for=20JS=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Classes/Eel/Helper/IncludeAssetsHelper.php | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/Classes/Eel/Helper/IncludeAssetsHelper.php b/Classes/Eel/Helper/IncludeAssetsHelper.php index 813eaf6..a837404 100644 --- a/Classes/Eel/Helper/IncludeAssetsHelper.php +++ b/Classes/Eel/Helper/IncludeAssetsHelper.php @@ -99,16 +99,9 @@ public function parseFilename(string $string): ?array } } - // Add type to javascript or modules - if (strpos($object['attributes'], ' type=') === false) { - switch ($object['type']) { - case 'js': - $object['attributes'] .= ' type="text/javascript"'; - break; - case 'mjs': - $object['attributes'] .= ' type="module"'; - break; - } + // Add type to javascript modules + if ($object['type'] === 'mjs' && strpos($object['attributes'], ' type=') === false) { + $object['attributes'] .= ' type="module"'; } // Add as="type" to preload CSS and JS