Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance #2

Open
rolandschuetz opened this issue May 8, 2019 · 3 comments
Open

Performance #2

rolandschuetz opened this issue May 8, 2019 · 3 comments

Comments

@rolandschuetz
Copy link

rolandschuetz commented May 8, 2019

I love the package and use it a lot. In a recent project, I had a performance problem and debugged rendering a few hours. In the end, it came down to Carbon.Link.

I prepared a test case while rendering a simple link tag 1000x took ~7.5 sec on my notebook in dev context, the Carbon.LInk version took ~30.5 sec. That difference is massive.

Not yet sure how to solve it, but I found it worth documenting it here.

Here's the test case

@rolandschuetz
Copy link
Author

@jonnitto Why do you convert a node to an identifier (here) to then convert it to a not with ${Neos.Link.convertUriToObject(link, node)}?

And why do you handle the section logic yourself, instead of using the NodeUri?

@jonnitto
Copy link
Member

Yeah, I know, I should refactor this. This will be a breaking one…

@rolandschuetz
Copy link
Author

What was the original intention behind this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants