Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix internal path cache #2

Open
amitport opened this issue Mar 13, 2015 · 0 comments
Open

fix internal path cache #2

amitport opened this issue Mar 13, 2015 · 0 comments
Assignees
Milestone

Comments

@amitport
Copy link
Member

Current internal path-cache implementation is error-prone (e.g., KeyPath.get("o.id") is not equal to KeyPath.get("o.['id']") and presents a memory leak (cache is never emptied).

Consider using something like memoize to avoid redundant path generation. Note that this means we cannot rely on instance to be intern and should implement an equals function for comparison (i.e., moving from keyPath === otherKeyPath to keyPath.equals(otherKeyPath).

@amitport amitport self-assigned this Mar 13, 2015
@amitport amitport added this to the v0.4.0 milestone Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant