Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the parameters for doip diagnosis are not extended, the maximum logical address of the client can only be up to 0x7ff. Should it be 0x0exx? #128

Open
xz0x opened this issue Sep 3, 2024 · 4 comments

Comments

@xz0x
Copy link

xz0x commented Sep 3, 2024

No description provided.

@kasperkarlsson
Copy link
Contributor

Hello,

The CAN base frame format includes an 11 bit arbitration ID value, whose possible range is hence 0x0-0x7FF.

I am not quite sure how to parse 0x0exx (as x is not a valid hexadecimal digit) and why this should be the maximum value. Can you please guide me through your reasoning here? 🙂

@xz0x
Copy link
Author

xz0x commented Sep 3, 2024

Hello, you're right. What I mean is diagnosis based on DOIP, not on CANbus, such as in Wireshark,
image
This is a session control for a 0x10 service, which requires route activation before proceeding。 In doip.py, the address of the external testing instrument is determined by two bytes, using a variable called send_arb_id. However, this is only up to 0x7ff, so that's what I meant
image

@xz0x
Copy link
Author

xz0x commented Sep 3, 2024

xx represents any data

@kasperkarlsson
Copy link
Contributor

kasperkarlsson commented Sep 3, 2024

Thank you for explaining! Let's ping an expert on DoIP and get their opinion 🙂

@Cr0wTom - do you have any input on this subject? Should the limit 0x7ff be 0xeff instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants