create mooclet when a mooclet experiment is imported #2205
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
VivekFitkariwala
requested changes
Feb 9, 2025
| @@ -509,6 +509,16 @@ export class ExperimentService { | |||
| user: UserDTO, | |||
| logger: UpgradeLogger | |||
| ): Promise<ValidatedExperimentError[]> { | |||
| const { experiments, validatedExperiments } = await this.verifyExperiments(experimentFiles, logger); | |||
There was a problem hiding this comment.
This function is no longer needed.
| try { | ||
| if ('moocletPolicyParameters' in experiment) { | ||
| if (!env.mooclets?.enabled) { | ||
| throw new BadRequestError( |
There was a problem hiding this comment.
If we throw an error, even valid experiments will not created.
This should be part of the verifyExperiment and the experiment should be skipped.
Users should see this problem before the actual import.
danoswaltCL
reviewed
Feb 10, 2025
| @@ -1270,7 +1270,7 @@ export class ExperimentController { | |||
| @CurrentUser() currentUser: UserDTO, | |||
| @Req() request: AppRequest | |||
| ): Promise<ValidatedExperimentError[]> { | |||
| return this.experimentService.importExperiment(experiments, currentUser, request.logger); | |||
| return this.moocletExperimentService.syncImportExperiment(experiments, currentUser, request.logger); | |||
There was a problem hiding this comment.
moocletExperimentService is the entrypoint for all imports? That feels a little funny, is there something that makes experimentService.importExperiment unable to accommodate delegating control to moocletExperimentService for mooclet imports only, while remaining the same for existing imports?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.