Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String monkeypatches confuse Faraday. #17

Open
pat opened this issue Jul 27, 2013 · 0 comments
Open

String monkeypatches confuse Faraday. #17

pat opened this issue Jul 27, 2013 · 0 comments

Comments

@pat
Copy link

pat commented Jul 27, 2013

Faraday can accept either strings or URI objects as a url for HTTP connections... and it determines which is which by checking whether the given url responds to host. Unfortunately, your monkeypatch adding the host instance method to String causes Faraday to raise an error if it's given a string url.

Perhaps it's worth reconsidering whether monkeypatching String so heavily is a wise idea - the more this is done, the greater potential for issues like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant