Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias option to every analysis node #9113

Closed
saleiva opened this issue Jul 26, 2016 · 11 comments
Closed

Add alias option to every analysis node #9113

saleiva opened this issue Jul 26, 2016 · 11 comments

Comments

@saleiva
Copy link
Contributor

saleiva commented Jul 26, 2016

Right now, the name of the tables created by the analysis nodes changes every time the parameters of the analysis change. An alias will be a -unique- name that you assign to an analysis node, so you can query that node always in the same way.

In Terms of UI this would be simple. Just adding an extra block for the alias on the analysis config and putting that alias on the layer list as the id of the node.

@alasarr
Copy link
Contributor

alasarr commented Jul 26, 2016

+1

@javisantana
Copy link
Contributor

@rochoa we need to discuss this at API level

@malkab
Copy link

malkab commented Jul 26, 2016

+1, definitively. This is a breakthrough improvement.

@rochoa
Copy link
Contributor

rochoa commented Aug 1, 2016

A couple of questions:

  • Do you expect the alias to be the same when you change some of the params?
  • Do you expect the alias to remain the same when some filters (from a widget) are applied?

Imagine you have a metro station points dataset.

You create a couple of different visualisations where you end having the same buffer, let's say 500m over each station, the nodes are in both visualisations are:

  1. [a0: stations] -> [a1: buffer 500m] -> [a2: intersection a1, b0].
  2. [b0: stations] -> [b1: buffer 500m] -> [b2: intersection b1, c0].

Now, from your proposal: what would you expect as the alias for the buffer in both cases?


In general, and related to @javisantana comment, is the alias something persistent or is something you want to have temporarily as you are working with it?

@saleiva
Copy link
Contributor Author

saleiva commented Aug 1, 2016

From my understanding it should be persisted.

On Aug 1, 2016 1:14 PM, "Raul Ochoa" [email protected] wrote:

A couple of questions:

  • Do you expect the alias to be the same when you change some of the
    params?
  • Do you expect the alias to remain the same when some filters (from a
    widget) are applied?

Imagine you have a metro station points dataset.

You create a couple of different visualisations where you end having the
same buffer, let's say 500m over each station, the nodes are in both
visualisations are:

  1. [a0: stations] -> [a1: buffer 500m] -> [a2: intersection a1, b0].
  2. [b0: stations] -> [b1: buffer 500m] -> [b2: intersection b1, c0].

Now, from your proposal: what would you expect as the alias for the buffer

in both cases?

In general, and related to @javisantana https://github.com/javisantana
comment, is the alias something persistent or is something you want to have
temporarily as you are working with it?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9113 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIENVY0Vsm96D1tUzsfxWLuC9thBy2_ks5qbdT_gaJpZM4JVBbi
.

@rochoa
Copy link
Contributor

rochoa commented Aug 1, 2016

Then, what about the rest of my questions?

@saleiva
Copy link
Contributor Author

saleiva commented Aug 1, 2016

Yes to both IMO

@rochoa
Copy link
Contributor

rochoa commented Aug 1, 2016

Current implementation gives you back the query associated with the node name. So nothing stops us from having an abstraction at client side to ask for the query associated with a node. But that should be also considered when we define the API at client side.

I don't think it's possible to make it persistent and at the same time keep the same alias when params and filters change.

For me, it starts to look like Named Analyses, à la Named Maps, so as @javisantana was pointing, we should think about the problem we want to solve at API level because this is a higher level abstraction over what we have now.

@malkab
Copy link

malkab commented Aug 22, 2016

Hi everybody from Geographica!

Any further progress / thoughs / planning about this? IMHO, this is a great improvement to mix Builder tools with custom SQL. Also great to test new and potential Builder tools algorithms.

@javisantana
Copy link
Contributor

This should be though with Analysis API -> CartoDB/Windshaft-cartodb#559

@xavijam xavijam removed this from the Builder milestone Dec 2, 2016
@urbanphes urbanphes removed their assignment May 26, 2017
@stale
Copy link

stale bot commented May 26, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 26, 2018
@stale stale bot closed this as completed Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants