Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

[Bug] Negitive new timer with dynamic vote times #251

Open
weeryan17 opened this issue Jan 31, 2021 · 0 comments
Open

[Bug] Negitive new timer with dynamic vote times #251

weeryan17 opened this issue Jan 31, 2021 · 0 comments
Assignees
Labels
module: music type: bug Something isn't working

Comments

@weeryan17
Copy link
Member

Describe the bug
this error is thrown sometimes with dynamically timed vote groups https://paste.traincarts.net/oboheyavow
I believe this has to do with voting near when the vote is supposed to run out (probably within milliseconds),. The new timer to finish the vote is passed in a negative time because of this on this line
https://github.com/CascadeBot/CascadeBot/blob/dev/src/main/java/org/cascadebot/cascadebot/utils/votes/VoteButtonGroup.java#L130

I'm fairly sure we can't easily reproduce this in prod, and might even be caused by a race condition with the vote finishing, but not saying it's finished before the time is attempted to be increased. Either way we need some way to handle if subsequent vote timers have a negative time.

@weeryan17 weeryan17 added type: bug Something isn't working module: music labels Jan 31, 2021
@weeryan17 weeryan17 self-assigned this Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: music type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant