You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The only blocking operation in this entire crate is the synchronize method on Core. This should be able to to be readily converted into a future.
This different API could then be exposed through an AsyncWriteHandle type. This type could offload most of its work by forwarding methods on the sync WriteHandle.
One issue to consider is that the WriteHandle currently calls this method on drop. This is not acceptable in an async context and could cause a deadlock. This could likely be solved by offloading the work done there on drop to be done when the Core is dropped. An easy hack for this would be to add a Box<dyn FnOnce(&Self)> to Core called on drop when the async feature is enabled.
The text was updated successfully, but these errors were encountered:
The only blocking operation in this entire crate is the
synchronize
method onCore
. This should be able to to be readily converted into a future.This different API could then be exposed through an
AsyncWriteHandle
type. This type could offload most of its work by forwarding methods on the syncWriteHandle
.One issue to consider is that the
WriteHandle
currently calls this method on drop. This is not acceptable in an async context and could cause a deadlock. This could likely be solved by offloading the work done there on drop to be done when theCore
is dropped. An easy hack for this would be to add aBox<dyn FnOnce(&Self)>
toCore
called on drop when the async feature is enabled.The text was updated successfully, but these errors were encountered: