From 8f096948be41e5c03822832d9b457cb0990533b7 Mon Sep 17 00:00:00 2001 From: Sean Lilley Date: Fri, 4 Oct 2024 19:36:14 -0400 Subject: [PATCH] Fix smooth normals size --- CHANGES.md | 4 ++++ src/core/src/FabricVertexAttributeAccessors.cpp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 8f830cb3..d922f9eb 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,9 @@ # Change Log +### v0.24.0 - 2024-11-01 + +* Fixed bug where smooth normals setting would crash. + ### v0.23.0 - 2024-10-01 * Fixed bug where tilesets and raster overlays were not being passed the correct custom ellipsoid. diff --git a/src/core/src/FabricVertexAttributeAccessors.cpp b/src/core/src/FabricVertexAttributeAccessors.cpp index 246f9e94..198c9bc4 100644 --- a/src/core/src/FabricVertexAttributeAccessors.cpp +++ b/src/core/src/FabricVertexAttributeAccessors.cpp @@ -163,8 +163,8 @@ NormalsAccessor NormalsAccessor::GenerateSmooth(const PositionsAccessor& positio } auto accessor = NormalsAccessor(); + accessor._size = normals.size(); accessor._computed = std::move(normals); - accessor._size = indices.size(); return accessor; }