Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rel for CesiumCartographicPolygon #639

Closed
lilleyse opened this issue Jan 26, 2024 · 2 comments · Fixed by #648
Closed

Use rel for CesiumCartographicPolygon #639

lilleyse opened this issue Jan 26, 2024 · 2 comments · Fixed by #648
Assignees

Comments

@lilleyse
Copy link
Contributor

Based on discussion in #632 there a few disadvantages of CesiumCartographicPolygon being a subclass of BasisCurves. We should consider using rel instead.

@r-veenstra
Copy link
Contributor

Decisions from standup

  • Prefered UX approach is to keep a single CesiumCartographicPolygonprim, vs splitting into two
  • @corybarr will look further into isolating the issue
  • If we can't figure it out prior to release, we'll likely update CesiumPolygonRasterOverlay to support pointing directly to BasisCurve + Globe Anchor combo, rather than the relapproach to keep UX simple
  • CesiumPolygonRasterOverlay can be re-added at a later time if needed

@corybarr
Copy link
Contributor

  • @corybarr will look further into isolating the issue

Having created a minimal example that does touch our codebase, I don't think we can keep a single CesiumCartographicPolygon prim for this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants