Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not extract roots for all gossip messages #7205

Open
twoeths opened this issue Oct 29, 2024 · 1 comment · May be fixed by #7208
Open

Do not extract roots for all gossip messages #7205

twoeths opened this issue Oct 29, 2024 · 1 comment · May be fixed by #7208
Assignees
Labels
meta-feature-request Issues to track feature requests.

Comments

@twoeths
Copy link
Contributor

twoeths commented Oct 29, 2024

Problem description

This is what happened if I don't extract roots for all messages (te/minimal_exchange_gossipsub_message branch)

Screenshot 2024-10-29 at 14 00 09

on a holesky node subscribing to all subnets, this helped reduced max 0.4% of gc time

we extract roots of all possible messages, especially beacon_attestation for:

  • if extracted root is known (skipped slot), we don't queue
  • if extracted root is not known, queue messages by root then by slot
  • actively search unknown gossip block by root

Solution description

considering the gossip validation logic of beacon_block:

  • it checks if proposer index is correct
  • it checks if proposer signature is correct
  • it checks if any blocks are known for the same proposer in the same slot

it's a guarantee we never have 2 blocks for the same slot passing through gossip validation

  • still extract roots for some first messages of slot
  • once gossip blocks are processed, no need to extract roots anymore
  • for skipped slots, gossip block never comes, we'll keep extracting roots like the current flow

Additional context

No response

@twoeths twoeths added the meta-feature-request Issues to track feature requests. label Oct 29, 2024
@twoeths twoeths self-assigned this Oct 29, 2024
@twoeths
Copy link
Contributor Author

twoeths commented Oct 29, 2024

part of #7186

@twoeths twoeths linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant