Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add image viewer #4117

Closed
wants to merge 15 commits into from
Closed

feat: add image viewer #4117

wants to merge 15 commits into from

Conversation

TheRamU
Copy link
Contributor

@TheRamU TheRamU commented Feb 24, 2024

  • Add image viewer
  • Fixed thread blocking during image upload

@vercel Vercel
Copy link

vercel bot commented Feb 24, 2024

@TheRamU is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

Your build has completed!

Preview deployment

@H0llyW00dzZ
Copy link
Contributor

LGTM

@H0llyW00dzZ
Copy link
Contributor

I cherry pick this pull requests, pretty useful

@H0llyW00dzZ
Copy link
Contributor

@TheRamU you may need fix this

image

image

image

@H0llyW00dzZ
Copy link
Contributor

H0llyW00dzZ commented Feb 25, 2024 •
edited
Loading

LGTM. I cherry pick now into my forks

now it should be fine from memory leaks especially on mobile

image

image

the only thing left now only fix this one later,

image

also that one it's not cause of image viewer

@H0llyW00dzZ
Copy link
Contributor

Show off I am so cool

image

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

Show off I am so cool

image

@TheRamU
Copy link
Contributor Author

TheRamU commented Feb 25, 2024

Show off I am so cool

image

So cool!

@H0llyW00dzZ
Copy link
Contributor

anyway this stable and pretty useful, why not merge into the main then release lmao

@H0llyW00dzZ
Copy link
Contributor

plus the function and ui can be reused for improve,etc

@TheRamU TheRamU closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcos-Montero Marcos-Montero Marcos-Montero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheRamU @H0llyW00dzZ @Issues-translate-bot @Marcos-Montero @actions-user