Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consideration: Engine should not return undefined for main channels? #3

Open
BroadcastGames opened this issue Oct 5, 2016 · 1 comment

Comments

@BroadcastGames
Copy link

Maybe it's a good idea to change the specifications / docs on the engine so it doesn't return undefined for things like "mainContent" and would return empty string instead? That way it's just empty or populated and no need to have a third state of undefined.

Take it as a suggestion / discussion point.

@ChicagoDave
Copy link
Owner

I guess there could be cases where mainContent is empty. We would handle this in FyreVMWeb.ts in the bottom function. For each channel, check for content and if it's undefined, make it an empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants