(Just a suggestion, strictly speaking, it's not a bug) When there is no stop codon at the end of the sequence, the length of the ORF may not be divisible by 3

[crazyxiaoj]

The code that should be modified is shown in the figure

[Chokyotager]

Hi, please submit a pull request.

[crazyxiaoj]

Hi, please submit a pull request.

Hi, I've forked a piece of code and completed most of the modifications. During the revision process, I noticed another problem:

if remove_nested:
    unnested_orfs = list()
    for orf_1 in orfs:
        appendable = True
        for orf_2 in orfs:
	    # Are you sure the following code is correct? 
            # The reverse sequence of the start and end values has not been converted here. 
            # Could this comparison be incorrect?
            if orf_2["start"] < orf_1["start"] and orf_2["end"] > orf_1["end"] and orf_1["end"] != -1:
                appendable = False
                break
        if appendable:
            unnested_orfs.append(orf_1)
    orfs = unnested_orfs

[Chokyotager]

Have you done any unit tests on the code?

Please submit a proper pull request and not just fork the code.

[crazyxiaoj]

Yes, I learned that I needed to fork a copy of the code to my GitHub repository, commit a change, and then request a pull.

[crazyxiaoj]

Finally, the testing is complete, and I expect to submit the pull request tomorrow afternoon. 🥳

[crazyxiaoj]

Hi, I've submitted the pull request. Please review the code closely and let me know if anything is wrong or unexpected.