Mm/prc 0 propagate error details (#57)

Release 5.3.2

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 
+## [5.3.2] - 2024-02-08
+
+### Fixed
+
+Error details of external HTTP error resposes are propagated correctly
+
 ## [5.3.1] - 2023-10-25
 
 ### Fixed

package.json

@@ -1,6 +1,6 @@
 {
   "name": "lambda-essentials-ts",
-  "version": "5.3.1",
+  "version": "5.3.2",
   "description": "A selection of the finest modules supporting authorization, API routing, error handling, logging and sending HTTP requests.",
   "main": "lib/index.js",
   "private": false,

src/util.ts

@@ -50,7 +50,7 @@ export function serializeAxiosError(error: AxiosError): SerializedAxiosError | u
   const { status, data } = error.response;
   return {
     status: data.originalStatusCode ?? status, // Propagate original status code of ClientException
-    details: data.details ? data.details : data, // Prevent wrapping of Exception
+    details: data.details && Object.keys(data.details).length > 0 ? data.details : data, // Prevent wrapping of Exception
   };
 }
 

tests/util.test.ts

@@ -115,6 +115,36 @@ describe('Util', () => {
       const serializedError = serializeAxiosError(error as any);
       expect(serializedError).toEqual(expected);
     });
+
+    test('serializes non-Exception objects which also have "details" field', () => {
+      const expected = {
+        details: {
+          details: {},
+          error,
+        },
+        status: 500,
+      };
+
+      const axiosErrorWithNonExceptionError: AxiosError = {
+        isAxiosError: true,
+        message: 'test-message',
+        response: {
+          data: {
+            details: {},
+            error,
+          },
+          status: 500,
+          config: {},
+          headers: null,
+          statusText: 'test-status-text',
+        },
+        config: {},
+        name: 'test-name',
+        toJSON: () => ({}),
+      };
+      const serializedError = serializeAxiosError(axiosErrorWithNonExceptionError as any);
+      expect(serializedError).toEqual(expected);
+    });
   });
 
   describe('redactSecret', () => {