Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #37

Open
11 tasks
passi246 opened this issue Aug 1, 2016 · 0 comments
Open
11 tasks

Review #37

passi246 opened this issue Aug 1, 2016 · 0 comments

Comments

@passi246
Copy link
Collaborator

passi246 commented Aug 1, 2016

CiRestClientBundle/resources/config/services.yml

  • Use class parameters consistently

CiRestClientBundle/Services/RestClient.php

  • Reduce api (setContentType ), if not necessary

CiRestClientBundle/DependencyInjection/CircleRestClientExtension.php

  • Redesign (config creation)

CiRestClientBundle/Exceptions/*Exception.php

  • Rework Exceptions

CiRestClientBundle/Parsers/HTTPHeadersParser.php

  • Rework

CiRestClientBundle/Tests

  • Rename Unit to Functional
  • Remove Bootstrap.php~ (+ gitignore)

CiRestClientBundle/Tests/Unit/RestClientTest.php

  • L55 "=" indent

CiRestClientBundle/Tests/Functional/Parsers/HTTPHeadersParserTest.php

  • L83 "=" indent

CiRestClientBundle/Tests/Functional/Services/CurlTest.php

Circle/RestClientBundle/Traits/Assertions.php

  • Assertions should assert :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@passi246