Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(migration): redo migration for hub v2 #114

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Conversation

benjaminbollen
Copy link
Member

fixes #113

@benjaminbollen benjaminbollen marked this pull request as ready for review March 1, 2024 18:15
jaensen
jaensen previously approved these changes Mar 6, 2024
Copy link
Contributor

@jaensen jaensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - pf ¯_(ツ)_/¯

# Conflicts:
#	src/hub/Hub.sol
#	src/hub/IHub.sol
src/hub/Hub.sol Outdated
* @param _avatars array of avatar addresses to migrate
* @param _amounts array of amounts in inflationary v1 units to migrate
*/
function migrate(address _owner, address[] calldata _avatars, uint256[] calldata _amounts) external {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, seems to miss a modifier ⚠️

Copy link
Member Author

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires changes! needs the modifier

@benjaminbollen benjaminbollen merged commit dabb49b into develop Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💪Done
Development

Successfully merging this pull request may close these issues.

migration
2 participants