Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications of receiving Circles to personal wallet, are displayed on the shared wallet #629

Closed
louilinn opened this issue Mar 21, 2023 · 9 comments · Fixed by #686
Closed
Assignees
Labels
a priority ★★☆ bug 💥 Something isn't working confusion 😕 Something is confusing the users

Comments

@louilinn
Copy link
Collaborator

louilinn commented Mar 21, 2023

Describe the bug
Notifications of receiving Circles to personal wallet, are displayed on the shared wallet

To Reproduce
Steps to reproduce the behavior:

  1. Go to a shared wallet that you own and which holds circles you can transfer to your personal wallet.
  2. Send Circles to your personal wallet
  3. See the success message for the transaction
  4. Wait (in your shared wallet)
  5. See a received message notification for the transferred Circles arriving to your personal wallet

Expected behavior
Step 5 should not happen unless you are back in your personal wallet.

https://www.figma.com/file/ZTqF54s6CSHTwAxp0U0JjQ/Circles-myxogastria?node-id=9211-21071&t=hr3EsnnFUt5qYu24-0

Related: #529

@louilinn louilinn added bug 💥 Something isn't working a priority ★★☆ confusion 😕 Something is confusing the users labels Mar 21, 2023
@louilinn
Copy link
Collaborator Author

@triaslucia this is filed, update priority if as you wish

@llunaCreixent
Copy link
Member

I also saw the issue when I'm logged in my personal wallet and I see the notifications of my SW

@triaslucia
Copy link

triaslucia commented Apr 5, 2023

what notification do you see on the SW @llunaCreixent , like if someone transfers CRC to a SW you got the notification on your Individual one?

@louilinn Is it possible to add to each notification the name of the wallet directly affected to the action the pop-up is related to? if yes I can work on making the design change on the notification to always include this.

@triaslucia
Copy link

Screenshot 2023-04-05 at 16 58 40

  1. I open my individual wallet, and a SW at the same time
  2. Transfer 10 CRC from the individual to the SW
  3. Got the notification of "successfully send 10 CRC" on the individual wallet.
  4. I get on both wallets at the same time the notification of "having received the CRC"

@llunaCreixent
Copy link
Member

what notification do you see on the SW @llunaCreixent , like if someone transfers CRC to a SW you got the notification on your Individual one?

@triaslucia I did the same test as you

@louilinn
Copy link
Collaborator Author

louilinn commented Apr 6, 2023

It also sometimes happens that you gt a received notification even if you don't have access to the receiving wallet.

@louilinn
Copy link
Collaborator Author

louilinn commented Apr 6, 2023

@triaslucia What I remember we have said in our meetings was to not have notifications pop up for other wallets, except ubi. So I don't think we need new designs? We would just fix this bug as in removing received notifications for wallets that you are not in atm.

@louilinn
Copy link
Collaborator Author

louilinn commented May 8, 2023

To do:

  • this has also been reported to happen to wallets that you do not own - look into how this can happen
  • remove received notifications for other wallets than your own

@mikozet mikozet linked a pull request May 12, 2023 that will close this issue
@mikozet
Copy link
Collaborator

mikozet commented May 12, 2023

regarding:

  • this has also been reported to happen to wallets that you do not own - look into how this can happen

I believe it should be corrected as well although I wasn't able to replicate it and tested it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a priority ★★☆ bug 💥 Something isn't working confusion 😕 Something is confusing the users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants