-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add account data deletion functionality #738
Add account data deletion functionality #738
Conversation
✅ Deploy Preview for preview-review-circles-garden ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Current text:
Suggested text
Another suggestion I have is to add a link to edit profile view in "Settings". |
Here my proposed text:
|
Updated suggestion: We do not plan to delete the transfer notes, but I will discuss with product. In that case we should add this in a different task as it will involve much more work. Suggested text
Thanks @Lluna |
751e646
to
fbb8035
Compare
fbb8035
to
8b7e36e
Compare
|
The API is ready with 2 new endpoints (deployed already in staging and production):
For the 2nd endpoint I suggest that it's used for the following 3 cases:
|
Also, should the delete option be available even when the Safe is not deployed (i.e. circles account not created)?? |
As it is implemented now, only the owner of the profile can delete the profile entry, and it has to prove the ownership of the safe address through the subgraph. The subgraph will only register ownership of safes once they are deployed. |
The core method for deleting the user will be available with |
So nothing else is possible? Without a lot of changes? |
For allowing users that haven't deployed their safe to remove the profile, we could verify on those cases the future ownership of the Safe by asking the relayer db |
b17dbb0
to
d35570b
Compare
We could consider adding a route to Edit profile in settings too? |
Needs fixing:
|
new FAQ link https://joincircles.net/faq/profile-data-deletion/ |
Problem remaining: avatar in onboarding step is wrong after avatar upload |
0c2d58b
to
e8b7de9
Compare
Behaviour for documentation Edit profile
Delete profile
Onboarding / Account creation
* unassociated pictures will be deleted periodicly from aws instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
No description provided.