Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Test CI for PRs from Forks #150

Open
sajanrajdev opened this issue May 10, 2022 · 2 comments
Open

Fix Test CI for PRs from Forks #150

sajanrajdev opened this issue May 10, 2022 · 2 comments
Assignees
@sajanrajdev

Comments

@sajanrajdev
Copy link
Contributor

Currently, PRs opened from a fork seem to be failing their Test CI job with the following:

image

Needs further investigation...
@sajanrajdev sajanrajdev self-assigned this May 10, 2022
@shuklaayush
Copy link
Contributor

This is because repository secrets (ALCHEMY_KEY in our case) are not available to workflows originating from a fork due to security reasons

@sajanrajdev
Copy link
Contributor Author

This is because repository secrets (ALCHEMY_KEY in our case) are not available to workflows originating from a fork due to security reasons

@shuklaayush, thanks for the insights. Good to know! I looked deeper into this and found that there are no plans from GH to allow this in the future. It would probably not make sense for us to allow it either way.

My suggestion is that we either ask contributors to PR from the base repo (@Ajand and @brianendo) or, if not possible, to include an ScreenShot of the tests passing for them locally within their PR.

For the moment, these two PRs are failing with this error:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sajanrajdev sajanrajdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sajanrajdev @shuklaayush